Re: lynx-dev lynx2.8.5dev.16i.patch.gz

[Thomas Dickey]

On Tue, 6 Jan 2004, Gisle Vanem wrote:

> "Thomas Dickey" <address@hidden> said:
>
> > I don't see anything interesting at line 4890 (just a right-curly-brace):
>
> This is at line 4873 after appying the patch
> ftp://invisible-island.net/temp/lynx2.8.5dev.16i.patch.gz
> (the latest AFAICS):
>
> #ifdef EXP_NESTED_TABLES
>     if (nested_tables) {
>         enclosing = Stbl_get_enclosing(me->stbl);
>         me->last_anchor_before_stbl = Stbl_get_last_anchor_before(me->stbl);
>         if (enclosing == NULL) {
>             Stbl_free(me->stbl);
>             free_enclosed_stbl(me);
>         } else {
>             if (me->enclosed_stbl == NULL)
>                 me->enclosed_stbl = HTList_new();
>             HTList_addObject(me->enclosed_stbl, me->stbl);
>             CTRACE((tfp, "endStblTABLE: postpone free %p\n", me->stbl));
>         }
>         me->stbl = enclosing;
>     } else {
>         Stbl_free(me->stbl);
>         me->stbl = NULL;

>         while (line != NULL &&     << line 4890
>                line != text->last_line &&
>                HText_TrueEmptyLine(line, text, FALSE)) {

I see a chunk like this which should be around line 3400:

@@ -3408,15 +3420,14 @@
            return;                     /* Do not add a blank line at start */
 #endif

-       while (line != text->last_line &&
-                       HText_TrueEmptyLine(line, text, FALSE)) {
+       while (line != NULL &&
+              line != text->last_line &&
+              HText_TrueEmptyLine(line, text, FALSE)) {
            if (newlines == 0)
                break;
            newlines--;         /* Don't bother: already blank */
            line = line->prev;
        }
-    } else if (AT_START_OF_CELL(text)) {
-       newlines = 1;                   /* New line to get a correct offset */
     } else {
        newlines++;                     /* Need also to finish this line */
     }

I'm guessing there's something wrong with your patch utility.

>     }
> #else
>     Stbl_free(me->stbl);
>     me->stbl = NULL;
> #endif
> ------
>
> Did'nt see anything in the patch that removed that while-loop.
> Should it not be there?
>
> --gv
>
>
> ; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden
>

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net

; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden