lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dev.15 progress (was: Re: lynx-dev screen not redisplaying cleanl


From: Leonid Pauzner
Subject: Re: dev.15 progress (was: Re: lynx-dev screen not redisplaying cleanly)
Date: Sat, 19 Apr 2003 15:20:20 +0400 (MSD)

16-Apr-2003 19:23 Thomas Dickey wrote:

>> > I saw those - but want to focus on bug fixes to close out dev.15 rather
>> > than improvements.
>>
>> My two patches from 6-7 April just complete changes that are already in
>> dev14i snapshot.

> I'll get to it (right now I'm still working to repair the archive tools -
> the compilers available for the new host are not compatible with the old ;-).
:-)

I have discovered two more minor items (attached):
the first is to avoid heavy HASH_FUNCTION calls in HTAnchor_delete,
and the second is parsing #fragment left-to-right in few src/*.c files
(no test examples, but I am pretty sure we should change strrchr to strchr
in few places below).


diff -u -p -r LYNX2-8-.14H/src/html.c LYNX2-8-.14Z/src/html.c
--- LYNX2-8-.14H/src/html.c     2003-04-02 14:21:50.000000000 +0000
+++ LYNX2-8-.14Z/src/html.c     2003-04-19 13:11:16.000000000 +0000
@@ -3568,7 +3549,7 @@ PRIVATE int HTML_start_element ARGS6(
             *  set. - FM && KW
             */
            StrAllocCopy(me->map_address, me->node_anchor->address);
-           if ((cp = strrchr(me->map_address, '#')) != NULL)
+           if ((cp = strchr(me->map_address, '#')) != NULL)
                *cp = '\0';
            StrAllocCat(me->map_address, "#");
            StrAllocCat(me->map_address, id_string);
diff -u -p -r LYNX2-8-.14H/src/lycharut.c LYNX2-8-.14Z/src/lycharut.c
--- LYNX2-8-.14H/src/lycharut.c 2003-04-02 14:21:50.000000000 +0000
+++ LYNX2-8-.14Z/src/lycharut.c 2003-04-19 13:14:10.000000000 +0000
@@ -2538,7 +2538,7 @@ PUBLIC void LYHandleMETA ARGS4(
            /* id_string seems to be used wrong below if given.
               not that it matters much.  avoid setting it here. - kw */
            if ((strncmp(href, "http", 4) == 0) &&
-               (cp = strrchr(href, '#')) != NULL) {
+               (cp = strchr(href, '#')) != NULL) {
                StrAllocCopy(id_string, cp);
                *cp = '\0';
            }
diff -u -p -r LYNX2-8-.14H/src/lymap.c LYNX2-8-.14Z/src/lymap.c
--- LYNX2-8-.14H/src/lymap.c    2003-04-02 14:21:50.000000000 +0000
+++ LYNX2-8-.14Z/src/lymap.c    2003-04-19 13:15:58.000000000 +0000
@@ -547,7 +547,7 @@ PRIVATE int LYLoadIMGmap ARGS4 (
     } else if (LYRequestTitle && *LYRequestTitle &&
               strcasecomp(LYRequestTitle, "[USEMAP]")) {
        StrAllocCopy(MapTitle, LYRequestTitle);
-    } else if ((cp=strrchr(address, '#')) != NULL) {
+    } else if ((cp=strchr(address, '#')) != NULL) {
        StrAllocCopy(MapTitle, (cp+1));
     }
     if (!(MapTitle && *MapTitle)) {

Attachment: d-hash.pat
Description: Binary data

Attachment: d-strrch.pat
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]