[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev Re: [PATCH 2.8.4dev.18] GridText.c cleanup
From: |
Vlad Harchev |
Subject: |
Re: lynx-dev Re: [PATCH 2.8.4dev.18] GridText.c cleanup |
Date: |
Sat, 3 Mar 2001 22:18:18 +0400 (SAMT) |
On Sat, 3 Mar 2001, Thomas Dickey wrote:
> On Sat, Mar 03, 2001 at 01:03:39PM +0400, Vlad Harchev wrote:
> > On Sat, 3 Mar 2001, Ilya Zakharevich wrote:
> >
> > > On Sun, Feb 25, 2001 at 01:46:54AM -0500, Ilya Zakharevich wrote:
> > > > This patch does not add any new functionality. All I did was I went
> > > > through more than 1000 lines of extremely badly written obfuscated C
> > > > code
> > > > worthy of a first year CS student...
> >
> > As for my opinion on this and previous cleanup patch: I think we shouldn't
> > apply it, unfortunately - because there are unpublished patches that are
> > made against old version of GridText.c - e.g. in Klaus's tree and yes, in
> > mine too. Applying your cleanup patch will break those patches horribly.
>
> since it's getting time to think about 2.8.4 pre-release, I'd rather see
> only patches for bug-fixes (cleanup patches per se introduce bugs as often
> as they fix them).
I hope you won't apply GridText.c cleanup patch then :)
> otoh, unpublished patches are just that - things that I shouldn't have to
> take into account.
Yes, it's the most reasonable attitude.
> --
> Thomas E. Dickey <address@hidden>
> http://dickey.his.com
> ftp://dickey.his.com
>
> ; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden
>
Best regards,
-Vlad
; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden