Re: lynx-dev [PATCH] "change directory" command

[Vlad Harchev]

On Sat, 15 Jul 2000, Ismael Cordeiro wrote:

> On Mon, 12 Jun 2000, Vlad Harchev wrote:
> 
> > On Mon, 12 Jun 2000, Thomas Dickey wrote:
> > 
> > > On Mon, Jun 12, 2000 at 03:35:12PM +0500, Vlad Harchev wrote:
> > > > 
> > > >  Here is a first version of implementation of "change directory"
> > > >  command.
> > > 
> > > you have to be careful with this - I have a hunch that it'll break a lot
> > > of dired configuration.
> > 
> > What do you suspect exactly? I tested all dired ops and they worked fine.
> > And one of the proofs: chdir'ing to /tmp and then 'g'oing to '.' shows the
> > list of /tmp (so all seem correct) independant of the directory where lynx
> > was started.
> > Reloading of lynx.cfg works fine too, 'm' works too - seems most commands
> > are ok (I haven't encountered op for which behaviour became broken
> > changed).
> 
> It seems that Thomas is right, your patch broke something. In the prompt
> "D)ownload, or C)ancel" the "c" and "C" commands don't work anymore.
> Commenting out "#define "SUPPORT_CHDIR" in userdefs.h, as suggested in the
> CHANGES file, doesn't re-enable the commands above.

 It's not my patch's failure - Tom overlooked something in HTFWriter.c, the 
fix for this attached.
 
> By the way, I think that it would be better to make clear that what the
> command does is to change the _current_ directory by calling it "change
> current directory" everywhere and by changing SUPPORT_CHDIR to something like
> SUPPORT_CHCURDIR.

  I don't think that is right idea - what directory "change directory" command 
 could change beside current?

 Thanks for evaluating dev4. Seems nobody else uses it (probably Eduardo uses 
it too).

> Ismael
>[..] 

 Best regards,
  -Vlad

diff -ru old/src/HTFWriter.c fixed/src/HTFWriter.c
--- old/src/HTFWriter.c Tue Jun 27 09:41:30 2000
+++ fixed/src/HTFWriter.c       Mon Jul 17 15:08:34 2000
@@ -749,7 +749,7 @@
            _statusline(CANNOT_DISPLAY_FILE_D_OR_C);
        }
 
-       while(c != 'D') {
+       while(c != 'D' && c!='C' && c!=7) {
            c = LYgetch_single();
 #ifdef VMS
            /*


; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden