lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lynx-dev patch for another popup problem


From: Klaus Weide
Subject: lynx-dev patch for another popup problem
Date: Fri, 29 Oct 1999 19:55:55 -0500 (CDT)

* Mouse action in popups would lead to call of fancy_mouse() with
  wrong row number, which could lead to messed-up display as well
  as invalid memory access.

The logic was wrong, probably for as long as fancy_mouse was used.
(It seems that in most situations it didn't cause problems because
the offset error was consistent across calls.)

   Klaus

[ Question: does anyone have problems with the patch format,
  specifically the somewhat strange '2.16(w)'? If yes, let me know,
  and I'll avoid it. ]

Index: 2.16/src/LYForms.c
--- 2.16/src/LYForms.c Mon, 25 Oct 1999 09:01:18 -0500
+++ 2.16(w)/src/LYForms.c Fri, 29 Oct 1999 15:38:31 -0500
@@ -1134,7 +1134,7 @@
            cmd = LYK_QUIT;
 #ifndef USE_SLANG
        } else if (c == MOUSE_KEY) {
-           if ((cmd = fancy_mouse(form_window, i + 1 + window_offset, 
&cur_selection)) < 0)
+           if ((cmd = fancy_mouse(form_window, i + 1 - window_offset, 
&cur_selection)) < 0)
                goto redraw;
            if  (cmd == LYK_ACTIVATE)
                break;
Index: 2.16/src/LYOptions.c
--- 2.16/src/LYOptions.c Wed, 27 Oct 1999 21:44:23 -0500
+++ 2.16(w)/src/LYOptions.c Fri, 29 Oct 1999 15:38:32 -0500
@@ -2592,7 +2592,7 @@
            cmd = LYK_QUIT;
 #ifndef USE_SLANG
        } else if (c == MOUSE_KEY) {
-           if ((cmd = fancy_mouse(form_window, i + 1 + window_offset, 
&cur_choice)) < 0)
+           if ((cmd = fancy_mouse(form_window, i + 1 - window_offset, 
&cur_choice)) < 0)
                goto redraw;
            if  (cmd == LYK_ACTIVATE)
                break;


reply via email to

[Prev in Thread] Current Thread [Next in Thread]