lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lynx-dev patch: remove a dozen of `refresh_screen' from mainloop


From: Leonid Pauzner
Subject: lynx-dev patch: remove a dozen of `refresh_screen' from mainloop
Date: Fri, 15 Oct 1999 18:10:30 +0400 (MSD)

* LYMainLoop.c: remove a dozen of IMHO unused `refresh_screen' flags
  from LYK_HISTORY, LYK_PRINT, LYK_LIST, LYK_ADDRLIST, LYK_VLINKS where
  a new html page generated (any document update that may be displayed in
  "partial display" mode need not setting of `refresh_screen' flag).


[more refresh_screen instances could be eliminated but that probably a grey
zone where a different curses version may give a different visual result
so extensive testing/knowledge may be required].



This patch against dev12.


--- lymainlo.old        Fri Oct 15 16:52:40 1999
+++ lymainlo.c  Fri Oct 15 17:25:38 1999
@@ -1314,9 +1314,8 @@
 }

 #ifdef EXP_ADDRLIST_PAGE
-PRIVATE BOOLEAN handle_LYK_ADDRLIST ARGS2(
-    int *,     cmd,
-    BOOLEAN *, refresh_screen)
+PRIVATE BOOLEAN handle_LYK_ADDRLIST ARGS1(
+    int *,     cmd)
 {
     /*
      * Don't do if already viewing list addresses page.
@@ -1343,7 +1342,6 @@
      * a POST response. - kw
      */

-    refresh_screen = TRUE;  /* redisplay */
     if (LYValidate || check_realm) {
        LYPermitURL = TRUE;
        StrAllocCopy(lynxlistfile, newdoc.address);
@@ -2991,8 +2989,7 @@
     return;
 }

-PRIVATE BOOLEAN handle_LYK_HISTORY ARGS2(
-    BOOLEAN *, refresh_screen,
+PRIVATE BOOLEAN handle_LYK_HISTORY ARGS1(
     BOOLEAN,   ForcePush)
 {
     if (curdoc.title && strcmp(curdoc.title, HISTORY_PAGE_TITLE)) {
@@ -3029,7 +3026,6 @@
        newdoc.link = 1; /*@@@ bypass "recent statusline messages" link */
        FREE(curdoc.address);  /* so it doesn't get pushed */

-       *refresh_screen = TRUE;
        if (LYValidate || check_realm) {
            LYPermitURL = TRUE;
        }
@@ -3132,7 +3128,6 @@
            newdoc.internal_link = FALSE;
            curdoc.line = -1;
            Newline = 0;
-           *refresh_screen = TRUE; /* redisplay it */
        } else if (use_this_url_instead != NULL) {
            /*
             *  Got back a redirecting URL.  Check it out.
@@ -3411,9 +3406,8 @@
     }
 }

-PRIVATE BOOLEAN handle_LYK_LIST ARGS2(
-    int *,     cmd,
-    BOOLEAN *, refresh_screen)
+PRIVATE BOOLEAN handle_LYK_LIST ARGS1(
+    int *,     cmd)
 {
     /*
      * Don't do if already viewing list page.
@@ -3440,7 +3434,6 @@
      * a POST response. - kw
      */

-    *refresh_screen = TRUE;  /* redisplay */
     if (LYValidate || check_realm) {
        LYPermitURL = TRUE;
        StrAllocCopy(lynxlistfile, newdoc.address);
@@ -3976,8 +3969,7 @@
     }
 }

-PRIVATE void handle_LYK_PRINT ARGS4(
-    BOOLEAN *, refresh_screen,
+PRIVATE void handle_LYK_PRINT ARGS3(
     BOOLEAN *, ForcePush,
     int *,     old_c,
     int,       real_c)
@@ -4005,7 +3997,6 @@
        *ForcePush = TRUE;  /* see LYpush() and print_options() */
        if (check_realm)
            LYPermitURL = TRUE;
-       *refresh_screen = TRUE; /* redisplay */
     }
 }

@@ -4651,9 +4642,8 @@
     }
 }

-PRIVATE BOOLEAN handle_LYK_VLINKS ARGS2(
-    int *,     cmd,
-    BOOLEAN *, refresh_screen)
+PRIVATE BOOLEAN handle_LYK_VLINKS ARGS1(
+    int *,     cmd)
 {
     if (!strcmp((curdoc.title ? curdoc.title : ""),
                VISITED_LINKS_TITLE)) {
@@ -4678,7 +4668,6 @@
     newdoc.isHEAD = FALSE;
     newdoc.safe = FALSE;
     newdoc.internal_link = FALSE;
-    *refresh_screen = TRUE;
     if (LYValidate || check_realm) {
        LYPermitURL = TRUE;
        StrAllocCopy(lynxlinksfile, newdoc.address);
@@ -6734,7 +6723,7 @@
            break;

        case LYK_HISTORY:       /* show the history page */
-           if (handle_LYK_HISTORY(&refresh_screen, ForcePush))
+           if (handle_LYK_HISTORY(ForcePush))
                break;

            /* FALLTHRU */
@@ -6877,23 +6866,23 @@
            break;

        case LYK_PRINT:  /* print the file */
-           handle_LYK_PRINT(&refresh_screen, &ForcePush, &old_c, real_c);
+           handle_LYK_PRINT(&ForcePush, &old_c, real_c);
            break;

        case LYK_LIST:  /* list links in the current document */
-           if (handle_LYK_LIST(&cmd, &refresh_screen))
+           if (handle_LYK_LIST(&cmd))
                goto new_cmd;
            break;

 #ifdef EXP_ADDRLIST_PAGE
        case LYK_ADDRLIST:   /* always list URL's (only) */
-           if (handle_LYK_ADDRLIST(&cmd, &refresh_screen))
+           if (handle_LYK_ADDRLIST(&cmd))
                goto new_cmd;
            break;
 #endif /* EXP_ADDRLIST_PAGE */

        case LYK_VLINKS:  /* list links visited during the current session */
-           if (handle_LYK_VLINKS(&cmd, &refresh_screen))
+           if (handle_LYK_VLINKS(&cmd))
                goto new_cmd;
            break;





reply via email to

[Prev in Thread] Current Thread [Next in Thread]