Re: lynx-dev lynx2.8.3dev.4

[T.E.Dickey]

> In LYStrings.h, these prototypes changed from dev.3: 
>  
> extern void LYLowerCase PARAMS(( 
>         char *          buffer)); 
> extern void LYUpperCase PARAMS(( 
>         char *          buffer)); 
>  
> Which I believe is correct, to dev.4: 

probably - there was some ripple effect in HS's patch that led him to
that point; I did check and gcc's too lazy to warn on that (and my usual
Solaris cc is in between installs this week).
  
> extern void LYLowerCase PARAMS(( 
>         unsigned char * buffer)); 
> extern void LYUpperCase PARAMS(( 
>         unsigned char * buffer)); 
>  
> which seems wrong.  A character is a "char", not an "unsigned char". 
> Various other declarations appear to have been changed to match. 
> OS/390's C compiler seems also to disagree with the construct: 
>  
> c89 -DHAVE_CONFIG_H   -I../../.. -I../../../src -I../../../../lynx2-8-3 
> -I../../../../lynx2-8-3/src  -I../../../../lynx2-8-3 
> /WWW/Library/Implementation -D_XOPEN_SOURCE_EXTENDED=1 -D_ALL_SOURCE    
> -I../../../../lynx2-8-3/WWW/Library/Implementation/ 
> -DXMOSAIC_HACK -DACCESS_AUTH -c 
> ../../../../lynx2-8-3/WWW/Library/Implementation/SGML.c 
> ERROR CBC3280 ./../../../../lynx2-8-3/WWW/Library/Implementation/SGML.c:4631  
> Function argument assignment between types "const char*" and "const unsigned 
> char*" is not allowed. 
> WARNING CBC3280 
> ./../../../../lynx2-8-3/WWW/Library/Implementation/SGML.c:4640  Function 
> argument assignment between types "char*" and "unsigned char*" is not 
> allowed. 
> ERROR CBC3280 ./../../../../lynx2-8-3/WWW/Library/Implementation/SGML.c:4640  
> Function argument assignment between types "const char*" and "const unsigned 
> char*" is not allowed. 
> ERROR CBC3280 ./../../../../lynx2-8-3/WWW/Library/Implementation/SGML.c:4654  
> Function argument assignment between types "const char*" and "const unsigned 
> char*" is not allowed. 
> FSUM3065 The COMPILE step ended with return code 12. 
> FSUM3017 Could not compile 
> ../../../../lynx2-8-3/WWW/Library/Implementation/SGML.c. Correct the errors 
> and try again. 
> gmake[1]: *** [SGML.o] Error 3 
>  
> Why was this change made?  Can it be undone, or must I insert casts at 

I'll recheck, perhaps undo it.  (Either way there'll be some casts,
unfortunately).

> all places where the (char)<->(unsigned char) happens.  I get ERRORs 
> on strlen() and the second argument to strcpy(); WARNINGs on the 
> first argument to strcpy(), etc. 
>  
> -- gil 
> --  
> StorageTek 
> INFORMATION made POWERFUL 


-- 
Thomas E. Dickey
address@hidden
http://www.clark.net/pub/dickey