Re: lynx-dev 2.8.1rel.2 patches (long)

[Leonid Pauzner]

14-Nov-98 20:42 Klaus Weide wrote:
> Hello all,

>  I have just re-subscribed to the list, after some time away..
> I see lynx dev is alive and well, and has made progress, in spite of the
> somewhat (hmm...) messy code I left behind. (Sorry Leonid and others..
> it probably wasn't much fun cleaning up the chartrans stuff.)

Hello Klaus!
I want to add internal cache for html sources in Lynx,
will explain my point of view in a separate message,
currently I am not sure where the stream should be redirected
and a little lost with anchor structure survey,
so you help appreciated.


> *** lynx2-8-1.orig/src/LYBookmark.c   Wed Oct 14 07:23:56 1998
> --- lynx2-8-1/src/LYBookmark.c        Sat Nov 14 19:34:25 1998
>   /*
> +  * Check whether we have any visible (non-blank) chars.
> +  */
> + PRIVATE  BOOLEAN havevisible ARGS1(CONST char *, Title)
> + {
> +     CONST char *p = Title;
> +     unsigned char c;
> +     long unicode;
> +
> +     for ( ; *p; p++) {
> +     c = (unsigned char)(TOASCII(*p));
> +     if (c > 32 && c < 127)
> +         return(TRUE);
> +     if (c <= 32 || c == 127)
> +         continue;
> +     if (LYHaveCJKCharacterSet || !UCCanUniTranslateFrom(current_char_set))
> +         return(TRUE);
> +     unicode = UCTransToUni(*p, current_char_set);
> +     if (unicode > 32 && unicode < 127)
> +         return(TRUE);
> +     if (c <= 32 || (c >= 127 && c <= 160) || c == 0xad)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                       This line is ISO-8859 specific

> +         continue;
> +     if (unicode >= 0x2000 && unicode < 0x200f)
> +         continue;
> +     return(TRUE);
> +     }
> +     return(FALSE); /* if we came here */
> + }


> ! PRIVATE  char* title_convert8bit ARGS1(CONST char *, Title)
>   {
>       CONST char *p = Title;
>       char temp[256];
> +     char *p0;
>       char *q = temp;
>       char *comment = NULL;
>       char *ncr     = NULL;
>       char *buf = NULL;
> +     int charset_in  = current_char_set;
> +     int charset_out = -1;
                       ^^^^^
                       Why not   = UCGetLYhndl_byMIME("us-ascii"); ?
                       I was trying hard to eliminate -1 where possible.

>       } else {
> !     int uck;
>       long unicode;
>       char replace_buf [10], replace_buf2 [10];

> !     if (charset_out < 0)
            ^^^^^^^^^^^^^^^^
> !         charset_out = UCGetLYhndl_byMIME("us-ascii");

>       uck = UCTransCharStr(replace_buf, sizeof(replace_buf), *q,
>                             charset_in, charset_out, YES);