Re: lynx-dev Proposed patch (DOS related)

[Leonid Pauzner]

>      * From: Doug Kaufman <address@hidden>
>      * Date: Thu, 8 Oct 1998 07:58:04 -0700 (PDT)
>      * Reply-To: address@hidden
>      * Sender: address@hidden
>      _________________________________________________________________

> I am having trouble understanding the logic behind the display of
> lynx.cfg in LYReadCFG.c. It seems to try to display a lynx.cfg file,
> either at the site specified in userdefs.h (for VMS and those using
> configure) or in the helpfile directory (for DOS and Win32), instead
> of the active lynx.cfg. I am not sure that there is a reason to

It was done by me intentionally. For DOSPATH there is no standard location for
lynx.cfg, userdefs.h set it to "." and user set it to lynx_cfg_file in
environment or from command-line. The 'LYNXCFG_HELP' was supposed to point us
out to clear distribution's lynx.cfg as a source for about 90Kb of comments
(LYNX_CFG_FILE from autoconf seems to be a best candidate on UNIX).

Since lynx.cfg may now have an INCLUDE directive to render several cfg files
recursively (and "lynx.cfg info link" from Options Menu or Info Page render
included cfg files exactly as lynx does on startup), it may be possible (and
reasonable) to have a small add-on file e.g. file with a single line like
"PARTIAL:FALSE" or so. If this happen to be a small cfg file we may lost the
comments if will use your patch.


> believe that such a duplicate file might exist if the active lynx.cfg
> is in a different location. "lynx_cfg_file" must point to a lynx
> configuration file or lynx exits with an error message in LYMain.c. I
> would propose the following patch to view the active lynx.cfg instead.
> I don't see where this breaks anything. (Patch is against pre.6)
>                                Doug

> *** lynx2-8-1/src/LYGlobalDefs.h        Wed Sep 30 14:06:48 1998
> --- lynx2-8-1/src/LYGlobalDefs.h.new    Thu Oct  8 07:37:06 1998
> ***************
> *** 24,30 ****
>   #define DOWNLOAD_OPTIONS_HELP "Lynx_users_guide.html#RemoteSource"
>   #define HISTORY_PAGE_HELP     "keystrokes/history_help.html"
>   #define LIST_PAGE_HELP                "keystrokes/follow_help.html"
> - #define LYNXCFG_HELP          "lynx.cfg"
>   #define OPTIONS_HELP          "keystrokes/option_help.html"
>   #define PRINT_OPTIONS_HELP    "keystrokes/print_help.html"
>   #define UPLOAD_OPTIONS_HELP   "Lynx_users_guide.html#DirEd"
> --- 24,29 ----
> *** lynx2-8-1/src/LYReadCFG.c   Wed Sep 30 14:06:48 1998
> --- lynx2-8-1/src/LYReadCFG.c.new       Thu Oct  8 07:18:10 1998
> ***************
> *** 1237,1255 ****

>         LYforce_no_cache = TRUE;  /* don't cache this doc */

> - #if defined(HAVE_CONFIG_H) || defined(VMS)
> -       StrAllocCopy(temp, LYNX_CFG_FILE);
> - #else
> -       StrAllocCopy(temp, helpfilepath); /* FIXME: no absolute path */
> -       StrAllocCat(temp, LYNXCFG_HELP);  /* for lynx.cfg on DOS/Win32 */
> - #endif /* HAVE_CONFIG_H */
> -
>         BeginInternalPage (fp0, LYNXCFG_TITLE, NULL);
>         fprintf(fp0, "<pre>\n");
>         fprintf(fp0, "<em>This is read from your lynx.cfg file,\n");

>         fprintf(fp0, "please \"read\" distribution's <a href=\"%s\">lynx.cfg",
> !                    temp);
>         fprintf(fp0, "</a> for more comments.</em>\n\n");

>         fprintf(fp0, "    #<em>Your primary configuration %s</em>\n",
> --- 1237,1248 ----

>         LYforce_no_cache = TRUE;  /* don't cache this doc */

>         BeginInternalPage (fp0, LYNXCFG_TITLE, NULL);
>         fprintf(fp0, "<pre>\n");
>         fprintf(fp0, "<em>This is read from your lynx.cfg file,\n");

>         fprintf(fp0, "please \"read\" distribution's <a href=\"%s\">lynx.cfg",
> !                    lynx_cfg_file);
>         fprintf(fp0, "</a> for more comments.</em>\n\n");

>         fprintf(fp0, "    #<em>Your primary configuration %s</em>\n",

> __
> Doug Kaufman