[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: LYNX-DEV Bad bug in Lyn
From: |
Alan Rooks |
Subject: |
Re: LYNX-DEV Bad bug in Lyn |
Date: |
3 Nov 1996 21:09:26 U |
Reply to: RE>>LYNX-DEV Bad bug in Lynx 2.6
Bela Lubkin wrote:
> [Alan Rooks wrote about GridText bug, asking about using memset()]
> *** GridText.c.orig Thu Oct 17 08:48:54 1996
> --- GridText.c Sat Nov 2 17:27:32 1996
> ***************
> *** 282,294 ****
> * if the underline is not filled with dots.
> */
> if (underscore_string[0] != '.') { /* Make a line */
> ! char *p;
> ! for (p=underscore_string; p<underscore_string+(MAX_LINE-1); p++)
> ! *p = '.'; /* Used for printfs later */
> ! underscore_string[(MAX_LINE-1)] = '\0';
> ! for (p=star_string; p<star_string+(LINESIZE-1); p++)
> ! *p = '_'; /* Used for printfs later */
> ! star_string[(LINESIZE-1)] = '\0';
> }
>
> underline_on = FALSE; /* reset */
> --- 315,325 ----
> * if the underline is not filled with dots.
> */
> if (underscore_string[0] != '.') { /* Make a line */
> ! /* These strings are used for printfs later */
> ! memset(underscore_string, '.', sizeof underscore_string);
> ! underscore_string[sizeof underscore_string - 1] = '\0';
> ! memset(star_string, '.', sizeof star_string);
> ! star_string[sizeof star_string - 1] = '\0';
> }
>
> underline_on = FALSE; /* reset */
Right, except that you want to fill that star_string with '_', not '.'.
Is there a reason why you used sizeof xxx_string, instead of
sizeof xxx_string - 1, in the memset()'s?
Alan Rooks
;
; To UNSUBSCRIBE: Send a mail message to address@hidden
; with "unsubscribe lynx-dev" (without the
; quotation marks) on a line by itself.
;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: LYNX-DEV Bad bug in Lyn,
Alan Rooks <=