[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes Lw
From: |
Sylvain Rochet |
Subject: |
Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c |
Date: |
Tue, 16 May 2017 22:11:56 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Hi,
On Tue, May 16, 2017 at 09:13:56PM +0200, address@hidden wrote:
> Sylvain Rochet wrote:
> >I checked if the issue was still there is the current master/2.0 branch,
> >you are right, this bug was fixed in commit fb07a28c99 ("fixed bug
> >#36388 (PPP: checksum-only in last pbuf leads to pbuf with zero
> >length)") *FIVE* years ago.
> :-))
>
> Thanks, for jumping in, Sylvain!
>
> Marco, I know you always say you don't have the time to re-evaluate new
> verisons, but you could save us *and* yourself much time hunting those old
> bugs by just taking the time to upgrage ;-) There have been *many* bugs
> fixed since 1.4.1!
I can't agree more, putting 1.4.1 in production today looks like a
mistake.
> The possibility of code size increasement is something I always wanted to
> investigate (and fix if required), but I haven't found the time to do so,
> lately... :-(
Well, last time we checked, with PPP enabled, lwIP core size
increasement didn't cross the PPP code size decreasement:
https://lists.gnu.org/archive/html/lwip-devel/2015-03/msg00082.html
So, with PPP enabled, lwIP 2.0 is still probably lighter (or roughly
equivalent) than 1.4. I'm too lazy to check if this statement is still
true right now :-)
Sylvain
signature.asc
Description: Digital signature
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, (continued)
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, Marco Jakobs, 2017/05/15
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, Simon Goldschmidt, 2017/05/15
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, Marco Jakobs, 2017/05/15
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, Simon Goldschmidt, 2017/05/16
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, Sylvain Rochet, 2017/05/16
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, address@hidden, 2017/05/16
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, Marco Jakobs, 2017/05/16
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, address@hidden, 2017/05/17
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, Marco Jakobs, 2017/05/18
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c, Simon Goldschmidt, 2017/05/18
- Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c,
Sylvain Rochet <=