RE: [lwip-users] Struct packing/alignment problems

[Mountifield, Tony]

Hi Jani,

It was I who generated the patches, and I included updates to the example 
driver ethernetif.c to show the exact changes required to an ethernet driver.

But I agree with you that lwipopts.h is a better place from which to control 
the padding option.

Cheers
Tony


> -----Original Message-----
> From: Jani Monoses [mailto:address@hidden
> Sent: 04 May 2004 10:32
> To: Mailing list for lwIP users
> Subject: Re: [lwip-users] Struct packing/alignment problems
> 
> 
> > Exactly how did it not work? Correct alignment of header fields will
> > not break anything.
> 
> It just did not work whereas without the change it did, so I did not
> debug it further. The behaviour you want can be selected it's just not
> the default. And agreed, we should try making it simpler and 
> cleaner and
> will have to see if what you suggest below would work out.
> 
> But for now I'd like to keep it this way (Rule of least surprise for
> people who have been successfully running lwip/ethernet so far)
> 
> > 
> > I suspect the problem you have is in your ethernet driver, 
> the driver 
> > must be slightly altered to work with the alignment patch.
> 
> I didn't know about that.
> If you have a patch for the cleanups than I'm interested too, I don't
> like those ugly PACK directives either (Note however they are for
> packing and not padding the data, so padding only corrects one of the
> alignment issues).
> 
> Jani
> 
> 
> _______________________________________________
> lwip-users mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/lwip-users
> 


***********************************************************************************
This email, its content and any attachments is PRIVATE AND
CONFIDENTIAL to TANDBERG Television. If received in error please
notify the sender and destroy the original message and attachments.

www.tandbergtv.com
***********************************************************************************