Re: [lwip-users] Patch #1326 breaks TCP

[Karl Jeacle]

On Thu 16 Oct 03, 13:32:26 +0200, Zschocke, Florian wrote:
> The intention of the change is to move the for() loop out of the while()
> loop since you only need to find the end of the unacked queue once as the

OK, that makes sense.

> are right and the for() loop got lost somewhere in the patch. IIRC it should
> be at line 372 where useg is initialized. It should be pointing to the end
> of the unacked list when it enters the "else" branch in lines 458ff.

Yes, that would certainly fix things. If the for() was reintroducted
directly after "useg = pcb->unacked;" at line 372, everything should
be alright...

... and I've just tried this, and it does indeed make things work
again. Just need to check that pcb->unacked isn't NULL to start
with, so line 372 should be changed to:

  /* useg should point to last segment on unacked queue */
  useg = pcb->unacked;
  if (useg != NULL) {
    for (useg = pcb->unacked; useg->next != NULL; useg = useg->next);
  }

Karl