[lwip-users] [lwip] TCP pcb's in CLOSE_WAIT hang around forever + patch

[Paul Sheer]

Hi there,

I noticed some unfree'd pcb's that stick around.
Can someone check if my cheeky fix is a really
bad idea?

       }
     }
          
-    /* Check if this PCB has stayed too long in FIN-WAIT-2 */
-    if(pcb->state == FIN_WAIT_2) {
+    /* Check if this PCB has stayed too long after closing */
+    if(pcb->state >= FIN_WAIT_1) { /* psheer: was "if(pcb->state
+                                      == FIN_WAIT_2)" --> I don't
+                                      like my TCP sessions to
+                                      hang around for ever. What
+                                      does the RFC say?
       if((u32_t)(tcp_ticks - pcb->tmr) >
         TCP_FIN_WAIT_TIMEOUT / TCP_SLOW_INTERVAL) {
         ++pcb_remove;
       }
     }

best

-paul


>From 1 July 2002 my new Tel is . . . . . . . . .  +27 21 686 9634
Paul Sheer Consulting IT Services . . . Tel . . . +27 21 761 7224
Email . . . address@hidden . . . . . . Pager . . . 088 0057245
Linux development, cryptography, recruitment,  support,  training
http://www.icon.co.za/~psheer . . . . http://rute.sourceforge.net
L I N U X . . . . . . . . . . . .  The Choice of a GNU Generation
[This message was sent through the lwip discussion list.]