[lwip-users] [lwip] IMPORTANT: Ethernet driver implementors: please read this.

[leon . woestenberg]

A memory leak was found in the etharp.c and Ethernet drivers architecture.
Ethernet drivers' output code must follow this skeleton:


(See
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=1686&group_id=3159)

                                                                                
                                   
                                                                                
                                   
                                                                                
                                   
                                                                                
                                   
                                                                                
                                   
                                                                                
                                   
                                                                                
                                   
                                                                                
                                   
                                                                                
                                   
                                                                             
err_t ethif_output(struct netif       
                                                                             
*netif, struct pbuf *p, struct        
                                                                             
ip_addr *ipaddr)                      
                                                                             {  
                                   
                                                                             p 
= etharp_output(netif, ipaddr, p);  
                                                                                
                                   
                                                                             if 
(p != NULL)                        
                                                                             {  
                                   
                                                                             /* 
send out the packet */             
                                                                             
cs8900_output(netif, p);              
                                                                             /* 
clean any ARP left-overs */        
                                                                             
etharp_output_sent(p);                
                                                                             p 
= NULL;                             
                                                                             }  
                                   
                                                                             
return ERR_OK;                        
                                                                                
                                   
                                                                                
                                   
                                                                                
                                   
                                                                                
                                   




[This message was sent through the lwip discussion list.]