[lwip-devel] [patch #10086] mqtt.c : Remove useless LWIP_ASSERT_CORE_LOCKED()

[Simon Goldschmidt]

Update of patch #10086 (project lwip):

                  Status:                    None => Wont Do                
             Assigned to:                    None => goldsimon              
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #1:

The assert might be invalid in the current code, but the asserts define a
"contract" to the application. And since we could, in the future, change
'mqtt_client_new()' to call into the core stack, the assertion is valid here
(even if not required right now).

That prevents the need to change applications in the future: every "public"
(exported) function of the mqtt client asserts that it is called correctly.

And yes, you need to use (UN)LOCK_TCPIP_CORE appropriately.


    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?10086>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/