[lwip-devel] [patch #10368] Multiple fixes and enhancements in ALTCP TLS MBEDTLS

[Hamza Hajeir]

URL:
  <https://savannah.nongnu.org/patch/?10368>

                 Summary: Multiple fixes and enhancements in ALTCP TLS MBEDTLS
                   Group: lwIP - A Lightweight TCP/IP stack
               Submitter: hamzahajeir
               Submitted: Tue 27 Jun 2023 01:04:18 PM UTC
                Category: apps
                Priority: 6
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Tue 27 Jun 2023 01:04:18 PM UTC By: Hamza Hajeir <hamzahajeir>
Hello LwIP community!

I'm providing patches of several and various fixes and enhancements targeting
altcp_tls_mbedtls.c file, as follows:
0001- Copies the TCP flags out of the received puf, in which the application
can receive the correct PUSH flag set and act accordingly, either by waiting
other fragments or immediately process it.
The patch also adds a condition to the while loop to save unnecessare wasted
cycles when there's no available buffer in rx or rx_app buffers.

0002- Correctly free clients' tls configurations on close, preventing certain
memory leak. Servers are excluded from thie free operation; because they share
the same config. In an upcoming patch freeing the LISTEN connection close.

0003- Simple fixes of abort calls management.

0004- Freeing the SSL ticket and cache contexts by an appropriate call.

0005- Ensure conf-> (pkey,cert,ca) pointers value NULL when free.

0006- Adds the return value of mbedtls APIs: handshake and setup.

0007- Correctly close and free the tls configurations of a LISTEN pcb.

0008- Make use of handshake steps instead of one block call. This frees the
CPU for good amount of time when handshake is in the process of
receiving/sending data against the network.

0009- I'm not very sure, but this frees rx_app buffer on dealloc.

And in altcp_tls_mbedtls_mem.c:
0010- Corrects wrongly identified mbedTLS memory calloc/free configuration,
more details in: https://savannah.nongnu.org/bugs/?64299

The previous patches are based on a partially merged lwip library, which I
cherry-picked only mbedtls-related commits in master and release 2.1.x branch
to 2.1.2 release maintained by espressif (esp-lwip), So one might notice some
lines differences to the current master branch.

Beside, I've reviewed some of them multiple times, so these are not
chronologically in order. Given this, there might happen some ease-to-spot
conflicts.


Sincerely,
Hamza Hajeir






    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Tue 27 Jun 2023 01:04:18 PM UTC  Name:
0001-altcp_tls_mbedtls-Copy-received-TCP-flags.patch  Size: 1KiB   By:
hamzahajeir
Batch 1
<http://savannah.nongnu.org/patch/download.php?file_id=54879>
-------------------------------------------------------
Date: Tue 27 Jun 2023 01:04:18 PM UTC  Name:
0002-altcp_tls_mbedtls-Free-client-s-TLS-config-on-deallo.patch  Size: 2KiB  
By: hamzahajeir
Batch 1
<http://savannah.nongnu.org/patch/download.php?file_id=54880>
-------------------------------------------------------
Date: Tue 27 Jun 2023 01:04:18 PM UTC  Name:
0003-altcp_tls_mbedtls-Fix-abort-management.patch  Size: 1KiB   By:
hamzahajeir
Batch 1
<http://savannah.nongnu.org/patch/download.php?file_id=54881>
-------------------------------------------------------
Date: Tue 27 Jun 2023 01:04:18 PM UTC  Name:
0004-altcp_tls_mbedtls-Free-SSL-cache-and-session-tickets.patch  Size: 1KiB  
By: hamzahajeir
Batch 1
<http://savannah.nongnu.org/patch/download.php?file_id=54882>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?10368>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/