[lwip-devel] [bug #61663] PPP Debugging

[Ashley Duncan]

URL:
  <https://savannah.nongnu.org/bugs/?61663>

                 Summary: PPP Debugging
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: ashesman
            Submitted on: Sun 12 Dec 2021 09:17:48 PM UTC
                Category: PPP
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

Hi,

A very minor issue...  When trying to enable PPP debugging, I noticed two
problems:

The macros defined in ppp.h around line 60

#define IPCPDEBUG(a)    LWIP_DEBUGF(LWIP_DBG_LEVEL_WARNING, a)

are not correct I don't think as they always prevent enabling debug output.  I
think they should be

#define IPCPDEBUG(a)    LWIP_DEBUGF(PPP_DEBUG, a)

Secondly, uses of these macros have no newlines in the debug output which is
inconsistent with all other uses of LWIP_DEBUGF.  Example is 

IPCPDEBUG(("ipcp: up"));




    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?61663>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/