[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #10086] mqtt.c : Remove useless LWIP_ASSERT_CORE_LOC

From: Jonathan D
Subject: [lwip-devel] [patch #10086] mqtt.c : Remove useless LWIP_ASSERT_CORE_LOCKED()
Date: Wed, 7 Jul 2021 04:54:06 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0


                 Summary: mqtt.c : Remove useless LWIP_ASSERT_CORE_LOCKED()
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jona
            Submitted on: Wed 07 Jul 2021 08:54:04 AM UTC
                Category: apps
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None



In mqtt.c, several LWIP_ASSERT_CORE_LOCKED are irrelevant. The most obvious is
in mqtt_client_new which just does a calloc.
I also found that LWIP_ASSERT_CORE_LOCKED in mqtt_client_is_connected and
mqtt_set_inpub_callback are useless but they are not included in the patch.

As a sidenote, I have a separate thread to manage MQTT, does this means that
each call to function with LWIP_ASSERT_CORE_LOCKED must be surrounded by


File Attachments:

Date: Wed 07 Jul 2021 08:54:04 AM UTC  Name:
0001-mqtt.c-Remove-useless-LWIP_ASSERT_CORE_LOCKED.patch  Size: 710B   By:



Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]