[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #57734] MQTT broken with muti-segments data

From: Paul RATHGEB
Subject: [lwip-devel] [bug #57734] MQTT broken with muti-segments data
Date: Sat, 16 May 2020 09:29:34 -0400 (EDT)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.129 Safari/537.36

Follow-up Comment #7, bug #57734 (project lwip):

When data are segmented, mqtt_message_receive() (mqtt.c line 913 on master -
3f47b04f16a874c05def88dcda6b3e0a2d6684ce) fails. It returns -1 because it is a
short PUBLISH packet (mqtt.c line 729).

mqtt_parse_incoming don't support segmented data.

mqtt_message_received should probably not be called if msg_rem_len != 0. Also,
in case of segmented data, the length must be adapted when
mqtt_message_received is called.
It was the purpose of cpy_start up to the commit
        2cc420e434744f9f217f2e68f39cf08379517a94 it seems. Segmented data was OK
until then.

Also, commit df0699c143842e656176dfe65d89e183e697ef53 introduced another
problem by calling mqtt_message_received with incomplete data in the case of
multiple segments.


Reply to this item at:


  Message posté via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]