[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9876] Const-correctness fixes, pointer types for bu
|
From: |
Sylvain Rochet |
|
Subject: |
[lwip-devel] [patch #9876] Const-correctness fixes, pointer types for buffers & couple minor tweaks |
|
Date: |
Thu, 5 Dec 2019 18:14:50 -0500 (EST) |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0 |
Follow-up Comment #1, patch #9876 (project lwip):
Well… erm… I have mixed feelings about an API change just to change a
pointer type (void* and u8_t* is basically the same thing) and adding some
const hints to compiler. It does not fix any issue, does not add a feature,
does not even prepare to welcome a new feature, in my opinion it is quite
close to being just cosmetic and nitpick.
That would have been great before the 2.x release, now I'm not sure breaking
something that works with something doing exactly the same thing but in a
slightly different and incompatible way is worth it.
Sylvain
_______________________________________________________
Reply to this item at:
<https://savannah.nongnu.org/patch/?9876>
_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/