[lwip-devel] [bug #55566] ppp_free() needs to accept phase PPP_PHASE_TERMINATE

[Robert Krakora]

URL:
  <https://savannah.nongnu.org/bugs/?55566>

                 Summary: ppp_free() needs to accept phase PPP_PHASE_TERMINATE
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: robkrakora
            Submitted on: Fri 25 Jan 2019 01:57:53 AM UTC
                Category: PPP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: 2.1.1

    _______________________________________________________

Details:

ppp_free() needs to accept phase PPP_PHASE_TERMINATE.

/*
 * Release the control block.
 *
 * This can only be called if PPP is in the dead phase.
 *
 * You must use ppp_close() before if you wish to terminate
 * an established PPP session.
 *
 * Return 0 on success, an error code on failure.
 */
err_t ppp_free(ppp_pcb *pcb) {
  err_t err;
  LWIP_ASSERT_CORE_LOCKED();
  if (!(pcb->phase == PPP_PHASE_DEAD || pcb->phase == PPP_PHASE_TERMINATE)) {
    return ERR_CONN;
  }

  PPPDEBUG(LOG_DEBUG, ("ppp_free[%d]\n", pcb->netif->num));

  netif_remove(pcb->netif);

  err = pcb->link_cb->free(pcb, pcb->link_ctx_cb);

  LWIP_MEMPOOL_FREE(PPP_PCB, pcb);
  return err;
}




    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?55566>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/