|
From: | Andrey Vinogradov |
Subject: | [lwip-devel] [bug #54195] ethernet.c, 178 & 195: extra condition |
Date: | Wed, 27 Jun 2018 12:54:27 -0400 (EDT) |
User-agent: | Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3472.3 Safari/537.36 |
URL: <http://savannah.nongnu.org/bugs/?54195> Summary: ethernet.c, 178 & 195: extra condition Project: lwIP - A Lightweight TCP/IP stack Submitted by: andreyvinogradov Submitted on: Ср. 27 июня 2018 16:54:26 Category: Network drivers Severity: 3 - Normal Item Group: Compiler Warning Status: None Privacy: Public Assigned to: None Open/Closed: Open Discussion Lock: Any Planned Release: None lwIP version: git head _______________________________________________________ Details: At line 91: if (p->len <= SIZEOF_ETH_HDR) { ... goto free_and_return; } Next at line 178 & 195: if ((p->len < next_hdr_offset) || pbuf_remove_header(p, next_hdr_offset)) { ... goto free_and_return; } So p->len checks twice _______________________________________________________ Reply to this item at: <http://savannah.nongnu.org/bugs/?54195> _______________________________________________ Сообщение отправлено по Savannah https://savannah.nongnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |