[lwip-devel] [bug #54062] Inconsequent null pointer checks

[Matthias Hofmann]

URL:
  <http://savannah.nongnu.org/bugs/?54062>

                 Summary: Inconsequent null pointer checks
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: mhofmann
            Submitted on: Tue 05 Jun 2018 09:48:27 AM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: 2.0.3

    _______________________________________________________

Details:

Hey,

how are the rules for null pointer checks? Some functions contain null pointer
checks, some not.

A bug in our software leads to "funny", hard to debug results as a null
pointer traversed over tcp_abort() into the lwip Stack.
Checking the TCP RAW API some function handle null pointer gracefully by
returning an error, some check for null pointer via LWIP_ASSERT, some just use
pointers.

It would be nice if the lwip API function have a common behaviour handling
null pointers.
What are your opinions?

Cheer Matthias




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?54062>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/