[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9612] Bugfix: sntp server IP address not always sav
[lwip-devel] [patch #9612] Bugfix: sntp server IP address not always saved after DNS lookup
Wed, 4 Apr 2018 08:38:36 -0400 (EDT)
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36
Follow-up Comment #2, patch #9612 (project lwip):
During these days I'm trying to setup the SNTP client in lwip, so I
immediately noticed this bugfix.
Anyway I couldn't explain why sntp module needs to save the IP address, if
SNTP_SERVER_DNS is set.
sntp_request() starts resetting the IP address (if SNTP_SERVER_DNS is set), so
it appears to me .addr field is completely useless. Why do we care to save
the result of DNS query?
Maybe it is only useful if the application set the servername with
sntp_setservername() and later tries to get the IP address with
Reply to this item at:
Message sent via/by Savannah