lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9611] tftp client


From: Simon Goldschmidt
Subject: [lwip-devel] [patch #9611] tftp client
Date: Tue, 3 Apr 2018 15:46:56 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Update of patch #9611 (project lwip):

                 Summary:  tftp client/dhcp issue => tftp client            

    _______________________________________________________

Follow-up Comment #1:

Yes, having a TFTP client integrated with the server would be welcome. But
please:
- rename or add files to reflect their contents (server vs. client)
- name functions to reflect their usage (server vs. client; tftp_init() is a
really bad example here)
- keep one patch for one issue (tftp client) and don't mix it with a bugfix
(dhcp issue) - I've change the summary for this.

On the DHCP issue, you're probably right. However, after your change, it seems
like with "parse_sname_as_options != 0", the file name could be copied
multiple times?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9611>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]