[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9610] tcp_out: Fix updating remainder_flags in tcp_

From: Joel Cunningham
Subject: [lwip-devel] [patch #9610] tcp_out: Fix updating remainder_flags in tcp_split_unsent_seg
Date: Fri, 30 Mar 2018 13:23:28 -0400 (EDT)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/604.5.6 (KHTML, like Gecko) Version/11.0.3 Safari/604.5.6

Follow-up Comment #1, patch #9610 (project lwip):


Great find, your patch is correct.

Using remainder is in fact a typo and remainder_flags was intended.
'remainder' is the size of unsent segment that is being split off into a new
pbuf after unsent head is trimmed.

We have a unit test for the unsent segment splitting (see
test_tcp_persist_split), but it currently doesn't test on FIN data packets
(which is the only case this bug would present itself).


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]