[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #53396] unit tests build broken for msvc

From: Joel Cunningham
Subject: [lwip-devel] [bug #53396] unit tests build broken for msvc
Date: Tue, 20 Mar 2018 21:19:49 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0


                 Summary: unit tests build broken for msvc
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jcunningham
            Submitted on: Wed 21 Mar 2018 01:19:48 AM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head



Unit tests no longer build on msvc due to a link failure:

Error 33 error LNK2001: unresolved external symbol _lwip_win32_platform_diag
E:\projects\lwip-contrib\ports\win32\msvc\lwIP.lib(pbuf.obj) lwip_unittests

The unit test is relying on the port's cc.h rather than using a unit test
specific cc.h.  This means we need to disable mapping LWIP_PLATFORM_DIAG to
lwip_win32_platform_diag during the unit test build.  I took a stab a using
LWIP_TESTMODE, but the problem is that's defined in opt.h, which is not
included in/before cc.h resulting in an undefined token when trying to do #if

Other option would be to add a definition for lwip_win32_platform_diag to the
unit test sys_arch.c, but this feels hacky to me.  Maybe there's another
symbol we can use that's defined during the unit test?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]