[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9364] RFC7668 - 6lowpan over Bluetooth Low Energy -

From: Simon Goldschmidt
Subject: [lwip-devel] [patch #9364] RFC7668 - 6lowpan over Bluetooth Low Energy -- a new netif
Date: Wed, 14 Mar 2018 17:14:29 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36

Follow-up Comment #11, patch #9364 (project lwip):

OK while we're at it, you seem to be missing to set tot_len of the allocated
pbuf. You should pass 'size' to pbuf_alloc() instead of 127. Then you only
have to change p->payload. Also, check for NULL return value!

And I see no reason to call ble_addr_to_eui64() for every RX packet when
'peer_addr' only changes with L2CAP_EVENT_LE_INCOMING_CONNECTION packets...

Next, we'd need a way to pass 'peer_addr' via tcpip_inpkt(), which
unfortunately only takes pbuf and netif pointers. Maybe a good solution is to
somehow set 'peer_addr' as netif-related data. Something like
'rfc7668_if_set_peer_addr(peer_addr)'? Since we only have one peer for BLE for
now, this might work.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]