[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #53325] NetBIOS Responder should respond to "*" names

From: Jens Nielsen
Subject: [lwip-devel] [bug #53325] NetBIOS Responder should respond to "*" names for lwIP 2.0.3
Date: Wed, 14 Mar 2018 16:46:36 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36

Follow-up Comment #6, bug #53325 (project lwip):

Some notes:

* First part of struct netbios_answer is afaik same as struct
netbios_name_hdr, reuse (like struct netbios_resp does) or use the same member
names or at least the same code style
* The pbuf_free(p); at end of netbiosns_recv() is now inside if (netif_default
!= NULL) so it leaks if netif_default == NULL
* One memcpy should be MEMCPY
* Move size_t i; declaration to beginning of netbiosns_set_name()
* When doing the upper case conversion you might as well skip the memcpy
before and do toupper directly from 'hostname'
* The upper case enforcement doesn't apply if NETBIOS_LWIP_NAME is defined (if
that's desired)


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]