[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9579] unit: increase test timeout

From: Joel Cunningham
Subject: [lwip-devel] [patch #9579] unit: increase test timeout
Date: Sun, 4 Mar 2018 02:47:46 -0500 (EST)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/604.5.6 (KHTML, like Gecko) Version/11.0.3 Safari/604.5.6

Follow-up Comment #2, patch #9579 (project lwip):

If anyone is interested, I figured out that check can write out the duration
of each test to an xml file. On my MacBook Air (core 2 duo from 2012) the
switch to memcpy reduced the duration from 2.335124s to 0.004089s, on my win10
box (core 2 duo from 2009) it is even slower.

I think the speed up is coming from not calling fail_unless on each byte. 
fail_unless is macro'd to ck_assert_msg, which calls _mark_point when the
assertion is true.


It would be useful to always output the xml output when running
lwip_unittests.  Any thoughts?

For the Unix port, I have it writing lwip_unittests.xml in the same dir as the
lwip_unittest executable:

diff --git a/test/unit/lwip_unittests.c b/test/unit/lwip_unittests.c
index be74077..c33e9d6 100644
--- a/test/unit/lwip_unittests.c
+++ b/test/unit/lwip_unittests.c
@@ -86,6 +86,7 @@ int main(void)
   sr = srunner_create((suites[0])());
+  srunner_set_xml(sr, "lwip_unittests.xml");
   for(i = 1; i < num; i++) {
     srunner_add_suite(sr, ((suite_getter_fn*)suites[i])());


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]