[lwip-devel] [bug #53119] pppol2tp:NS count is uncorrect for hello message

[kaiqin lin]

URL:
  <http://savannah.nongnu.org/bugs/?53119>

                 Summary: pppol2tp:NS count is uncorrect for hello message
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: lin704932121
            Submitted on: Sun 11 Feb 2018 06:10:50 AM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

I use xl2tpd as server in ubuntu, but l2tp is disconnected after a while. What
I found is that the NS count is uncorrect for hello message. To fix the bug,
change code as fllows in pppol2tp_dispatch_control_packet() function:


  switch(messagetype) {
    /* Start Control Connection Reply */
    case PPPOL2TP_MESSAGETYPE_SCCRP:
      .....
      break;
    /* Incoming Call Reply */
    case PPPOL2TP_MESSAGETYPE_ICRP:
      .....
      break;
    /* Unhandled packet, send ZLB ACK */
    default:
      goto send_zlb;
  }
  return;

------------>

  switch(messagetype) {
    /* Start Control Connection Reply */
    case PPPOL2TP_MESSAGETYPE_SCCRP:
      .....
      break;
    /* Incoming Call Reply */
    case PPPOL2TP_MESSAGETYPE_ICRP:
      .....
      break;
    case PPPOL2TP_MESSAGETYPE_HELLO:
      pppol2tp_send_zlb(l2tp, l2tp->our_ns+1);
      break;
    /* Unhandled packet, send ZLB ACK */
    default:
      goto send_zlb;
  }
  return;






    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?53119>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/