[lwip-devel] [patch #9534] freertos: misc fixes, core locking check support.

[Douglas]

Follow-up Comment #3, patch #9534 (project lwip):

> Next, why should we retry sys_mutex_lock etc. after a timeout? I don't
expect such a timeout to happen when passing portMAX_DELAY, or is there
something I am missing? 

Looking at the source code it appears that xQueueSemaphoreTake and
xQueueGenericSend can only return pdPASS when given portMAX_DELAY when
INCLUDE_vTaskSuspend == 1 (which is the case for esp-open-rtos), but might
some use of FreeRTOS not use INCLUDE_vTaskSuspend == 1 and actually time out
in which case the caller retrying seems appropriate. In any case there does
not appear to be an error return value to report.

> Moving sys_jiffies to sys_arch.h doesn't work though: FreeRTOS headers are
deliberately not exported via sys_arch.h in my port. 

Interesting so does that explain why there are 'struct _sys_mut' etc - was
wondering if esp-open-rtos should follow that approach?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9534>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/