Re: [lwip-devel] [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-1109-gd87740b

[Erik Ekman]

On 2 January 2018 at 20:50, address@hidden <address@hidden> wrote:

Erik,

nice to see you working on lwIP again :-)

I was thinking about giving the mdns code a second look and now it seems like it is actually used by someone :)

I am taking the week off work so I need some challenge..

 

Erik Ekman wrote:

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
        via  d87740bb963b915a9b194ee0f89a64b250674121 (commit)
       from  1c7a02429739e4d1b2858ad0fe5114f47a1d2ffa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d87740bb963b915a9b194ee0f89a64b250674121
Author: Erik Ekman <address@hidden>
Date:   Tue Jan 2 20:38:36 2018 +0100

     mdns: Fix multicast destination check for IPv6
          This broke when IPv6 got scopes added. Scopes/zones are checked
     even if none of the compared addresses are link local.

Shouldn't we fix ip6_addr_cmp() to always do the right thing instead of making the caller know if comparing zones is required or not? Or can't this be known in a generic way?

That is probably the best way to solve it. I will read up on the IPv6 scoping stuff and see if there is a better solution.

I just spotted this bug while setting up my test program and started digging.

Cheers 

Cheers,
Simon

          Result of the bug was that IPv6 replies were always sent unicast to
     the source instead of to the multicast address.
          Add ip-generic version that ignores IP zone info, since the v6 group
     address is not tied to any netif.

-----------------------------------------------------------------------

Summary of changes:
  src/apps/mdns/mdns.c       | 2 +-
  src/include/lwip/ip_addr.h | 4 ++++
  2 files changed, 5 insertions(+), 1 deletion(-)


hooks/post-receive