[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #52611] Incorrect use of ctype macros?

From: Mike Kleshov
Subject: [lwip-devel] [bug #52611] Incorrect use of ctype macros?
Date: Thu, 7 Dec 2017 05:25:40 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Follow-up Comment #7, bug #52611 (project lwip):

Looking at the code, I can see that right now the use of ctype macros in
ip4_addr.c is broken. It can lead to undefined behaviour. It became broken
when local implementation of those macros was replaced with reference to
standard macros, which behave differently.
The compiler warnings are genuine. Silencing them just hides the bugs. The
bugs need to be fixed either by adjusting lwip_is<...> macros to match
original behaviour or by 'fixing the caller' to match the behaviour of
standard ctype macros.
By the way, undefined behaviour does not manifest itself every time, so one
test does not prove anything.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]