[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [task #14724] thread safe ARP cache APIs

From: Joel Cunningham
Subject: [lwip-devel] [task #14724] thread safe ARP cache APIs
Date: Tue, 14 Nov 2017 16:30:08 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

Follow-up Comment #5, task #14724 (project lwip):

> - do we need the #if guards around including files?

Good point, since the header themselves are guarded internally with their own
switches, I can always include them

> - the names of the functions are a bit misleading. There's nothing depending
on netconns here. I'd probably move the functions to netifapi

I had the same thought about whether netconn was really the best place, but
there was an existing precedent of netconn_gethostbyname() which doesn't not
take a netconn parameter.  I will investigate netifapi

> Our static entries API seems to be missing a netif (as I think it's older
than that). Should we add a 'netif' parameter to the new API that means old
behaviour if NULL but replaces the 'ip_route' call if not NULL?

This would require an API change (or new API) in etharp.c since
etharp_add_static_entry doesn't take netif as a parameter.  Would you like to
see this as part of the task?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]