[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #52353] netif_issue_reports() not checking link/netif

From: Joel Cunningham
Subject: [lwip-devel] [bug #52353] netif_issue_reports() not checking link/netif up status
Date: Wed, 8 Nov 2017 10:58:09 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

Follow-up Comment #2, bug #52353 (project lwip):

I noticed one additional thing, some of the callers of netif_issue_reports are
checking that the admin state and link are up.

Callers that do:

 1) netif_set_up
 2) netif_set_link_up

Callers that don't:

 1) netif_set_ipaddr
 2) netif_ip6_addr_set_parts
 3) netif_ip6_addr_set_state

So I could add additional checks to the callers in the 'don't' list or I could
move the check down inside netif_issue_reports() and always call it from both
above lists.

I'm more in favor of checking inside netif_issue_reports() to reduce duplicate
checks and prevent new occurrences from being introduced in the future


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]