[lwip-devel] C99 in src/contrib/ports/win32/sys_arch.c

[Gisle Vanem]

The recent change in src/contrib/ports/win32/sys_arch.c:

static void sys_win_rand_init(void)
{
   ...
      err = GetLastError();
      char errbuf[128];

requires a C-99 compiler. Is that required now? IMHO, it'd better  be:

static void sys_win_rand_init(void)
{
  if(!CryptAcquireContext(&hcrypt, NULL, NULL, PROV_RSA_FULL, 0)) {
    DWORD err = GetLastError();
    LWIP_PLATFORM_DIAG(("CryptAcquireContext failed with error %d, trying to create 
NEWKEYSET", (int)err));
    if(!CryptAcquireContext(&hcrypt, NULL, NULL, PROV_RSA_FULL, 
CRYPT_NEWKEYSET)) {
      char errbuf[128];
      err = GetLastError();
      snprintf(errbuf, sizeof(errbuf), "CryptAcquireContext failed with error 
%d", (int)err);
      LWIP_UNUSED_ARG(err);
      LWIP_ASSERT(errbuf, 0);
    }
  }
}

--
--gv