[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9431] Removing the restriction on number of sockets

From: Simon Goldschmidt
Subject: [lwip-devel] [patch #9431] Removing the restriction on number of sockets
Date: Tue, 8 Aug 2017 15:19:09 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Follow-up Comment #1, patch #9431 (project lwip):

The patch has some drawbacks:
- duplicated code in alloc_socket(): this is really bad as two #if/else blocks
do the same. A bug fixed in one bug can remain in the 2nd block. Never do
- LWIP_SOCKET_OFFSET is not checked/obeyed everywhere
- alloc_socket() doesn't check for int overflow
- free_socket() doesn't follow our (old) C standard where variable
declarations and code must not be mixed
- Why is MEMP_MEM_MALLOC needed?

So far to the patch, I'll reply to the general discussion on the list.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]