[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9425] tcp: remove extra seg == NULL checks

From: Joel Cunningham
Subject: [lwip-devel] [patch #9425] tcp: remove extra seg == NULL checks
Date: Thu, 3 Aug 2017 11:43:25 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0


                 Summary: tcp: remove extra seg == NULL checks
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jcunningham
            Submitted on: Thu 03 Aug 2017 03:43:24 PM UTC
                Category: TCP
                Priority: 5 - Normal
                  Status: Need Info
                 Privacy: Public
             Assigned to: jcunningham
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None



Found some duplicate if (seg == NULL) checks in tcp_output that can be
combined.  Please see attached patch.

I wanted to double check that there wasn't a reason why LWIP_DEBUGF calls with
TCP_OUTPUT_DEBUG and TCP_CWND_DEBUG were guarded by #if/#endif.  I couldn't
see any reason why since LWIP_DEBUGF is a no-op when LWIP_DEBUG is not defined


File Attachments:

Date: Thu 03 Aug 2017 03:43:24 PM UTC  Name:
0001-tcp-remove-extra-seg-NULL-checks.patch  Size: 3KiB   By: jcunningham



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]