|Subject:||Re: [lwip-devel] [bug #50534] TFTP server does not copy terminating null of filename|
|Date:||Tue, 14 Mar 2017 09:12:01 +0100|
2017-03-14 4:42 GMT+08:00 Simon Goldschmidt <address@hidden>:
> Follow-up Comment #2, bug #50534 (project lwip):
>> This is my first bug report for this project, so let me know
>> if there's anything else I need to do
> In general, it's better to provide a diff/patch against a defined version.
> This helps us to see what's changed without manually comparing (where we need
> the version you have for manual diff).
> On top of that, a git diff save us the time for a commit (and keeps your name
> in the git log), but for such simple patches, a simple diff is probably enough
The diff of the commit looks scared. Why replace whole file?
cgit/lwip.git/commit/?id= 59973c96e4337bfc5f97bdc90e3cc9 4d8e70fcfc
$ file src/apps/tftp/tftp_server.c
src/apps/tftp/tftp_server.c: C source, ASCII text, with CRLF line terminators
|[Prev in Thread]||Current Thread||[Next in Thread]|