[lwip-devel] [patch #9186] mdns: Convert to use IPADDR4_INIT_BYTES for better readability

[Axel Lin]

Follow-up Comment #4, patch #9186 (project lwip):

I notice another build error when build unixsim:

$ make
cc -g -Wall -DLWIP_DEBUG -pedantic -Werror -Wparentheses -Wsequence-point
-Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual
-Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align
-Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wno-address
-Wunreachable-code -Wuninitialized -Wlogical-op -I. -I../../..
-I../../../../lwip/src/include -I../../../ports/unix/port/include -c
../../../../lwip/src/core/dns.c
In file included from ../../../../lwip/src/core/dns.c:89:0:
../../../../lwip/src/include/lwip/def.h:107:21: error: initializer element is
not a constant expression [-Werror=pedantic]
 #define PP_HTONL(x) ((((x) & 0xff) << 24) | \
                     ^
../../../../lwip/src/include/lwip/ip_addr.h:87:86: note: in expansion of macro
‘PP_HTONL’
 #define IPADDR6_INIT_HOST(a, b, c, d) { { { { PP_HTONL(a), PP_HTONL(b),
PP_HTONL(c), PP_HTONL(d) } } }, IPADDR_TYPE_V6 }
                                                                              
       ^~~~~~~~
../../../../lwip/src/include/lwip/prot/dns.h:133:37: note: in expansion of
macro ‘IPADDR6_INIT_HOST’
 #define DNS_MQUERY_IPV6_GROUP_INIT  IPADDR6_INIT_HOST(0xFF020000,0,0,0xFB)
                                     ^~~~~~~~~~~~~~~~~
../../../../lwip/src/core/dns.c:309:38: note: in expansion of macro
‘DNS_MQUERY_IPV6_GROUP_INIT’
 const ip_addr_t dns_mquery_v6group = DNS_MQUERY_IPV6_GROUP_INIT;
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../lwip/src/include/lwip/def.h:107:21: note: (near initialization for
‘dns_mquery_v6group.u_addr.ip6.addr[3]’)
 #define PP_HTONL(x) ((((x) & 0xff) << 24) | \
                     ^
../../../../lwip/src/include/lwip/ip_addr.h:87:86: note: in expansion of macro
‘PP_HTONL’
 #define IPADDR6_INIT_HOST(a, b, c, d) { { { { PP_HTONL(a), PP_HTONL(b),
PP_HTONL(c), PP_HTONL(d) } } }, IPADDR_TYPE_V6 }
                                                                              
       ^~~~~~~~
../../../../lwip/src/include/lwip/prot/dns.h:133:37: note: in expansion of
macro ‘IPADDR6_INIT_HOST’
 #define DNS_MQUERY_IPV6_GROUP_INIT  IPADDR6_INIT_HOST(0xFF020000,0,0,0xFB)
                                     ^~~~~~~~~~~~~~~~~
../../../../lwip/src/core/dns.c:309:38: note: in expansion of macro
‘DNS_MQUERY_IPV6_GROUP_INIT’
 const ip_addr_t dns_mquery_v6group = DNS_MQUERY_IPV6_GROUP_INIT;
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../lwip/src/include/lwip/def.h:107:21: error: large integer
implicitly truncated to unsigned type [-Werror=overflow]
 #define PP_HTONL(x) ((((x) & 0xff) << 24) | \
                     ^
../../../../lwip/src/include/lwip/ip_addr.h:87:86: note: in expansion of macro
‘PP_HTONL’
 #define IPADDR6_INIT_HOST(a, b, c, d) { { { { PP_HTONL(a), PP_HTONL(b),
PP_HTONL(c), PP_HTONL(d) } } }, IPADDR_TYPE_V6 }
                                                                              
       ^~~~~~~~
../../../../lwip/src/include/lwip/prot/dns.h:133:37: note: in expansion of
macro ‘IPADDR6_INIT_HOST’
 #define DNS_MQUERY_IPV6_GROUP_INIT  IPADDR6_INIT_HOST(0xFF020000,0,0,0xFB)
                                     ^~~~~~~~~~~~~~~~~
../../../../lwip/src/core/dns.c:309:38: note: in expansion of macro
‘DNS_MQUERY_IPV6_GROUP_INIT’
 const ip_addr_t dns_mquery_v6group = DNS_MQUERY_IPV6_GROUP_INIT;
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
../Common.mk:93: recipe for target 'dns.o' failed
make: *** [dns.o] Error 1


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9186>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/