[lwip-devel] [bug #49285] PPP doesn't get connected anymore after a link fail

[Sylvain Rochet]

Follow-up Comment #18, bug #49285 (project lwip):

Great!, thanks you very much for testing, time for the real fix then.


By the way, to answer various Simon's questions:

> That would mean removing the 'memset()' to parts of the ppp_pcb broke it?

Yes.


> Sylvain, in the commit message, you say that 'init' has been moved from
'connect' to first-init because one user wanted to change the default
configuration.
> Do all the protocols handle init being called only once correctly?

They should :-)


> I'm lost in checking how the original pppd code does that...

Init is actually called only once.

Resetting is done in the resetci fsm callbacks, which is called when protocol
send the first configure request frame, see fsm_sconfreq function.


> On the other hand, the remote side seems to terminate the connection, maybe
because of too many IPCP reqs?

Not here.


> Or because the old address is now requested?

Yes!


> How did the retry look with commit
"c751802fad4b0eda89965f575035cee318df29e7"? 

It worked, because the giant memset cleared the IPCP wanted options struct.

IPCP is special regarding that, I suppose but I am not sure, because of a
protocol design flaw on the old ADDRS protocol (which shouldn't be used
anymore) wanted options struct need to be changed to improve the chance of
converging. That's only a guess and I don't want to change that because it was
clearly done on purpose in pppd.


Anyway, I am very well aware that removing the giant memset between retries
may reveal bugs that were previously shadowed, but it was worth it to allow
user configuration.


Sylvain


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?49285>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/