[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9139] Invalid format string in dhcp.c

From: Thomas Mueller
Subject: [lwip-devel] [patch #9139] Invalid format string in dhcp.c
Date: Mon, 10 Oct 2016 07:39:22 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:49.0) Gecko/20100101 Firefox/49.0


                 Summary: Invalid format string in dhcp.c
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: tmu
            Submitted on: Mon 10 Oct 2016 07:39:20 AM GMT
                Category: DHCP
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None



Some error messages passed in calls to LWIP_ERROR() in 
src/core/ipv4/dhcp.c attempting to print a percent sign
contain invalid conversion specifiers. When compiling
both LWIP_DEBUG and LWIP_NOASSERT defined, a compiler
validating format strings emits warnings/errors accordingly:

./lwip-dist/src/core/ipv4/dhcp.c: In function 'dhcp_parse_reply':
./lwip-dist/src/core/ipv4/dhcp.c:1522:20: error: unknown conversion type
character 0x20 in format [-Werror=format=]
         LWIP_ERROR("len % 4 == 0", len % 4 == 0, return ERR_VAL;);

The attached patch fixes this.


File Attachments:

Date: Mon 10 Oct 2016 07:39:20 AM GMT  Name: dhcp-format.diff  Size: 1kB   By:



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]