[lwip-devel] [bug #47154] lwip_netconn_do_writemore doesn't clear conn->write_offset on fatal/routing error.

[Marco Veeneman]

URL:
  <http://savannah.nongnu.org/bugs/?47154>

                 Summary: lwip_netconn_do_writemore doesn't clear
conn->write_offset on fatal/routing error.
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: mave
            Submitted on: Mon 15 Feb 2016 12:53:49 PM GMT
                Category: sockets/netconn
                Severity: 3 - Normal
              Item Group: Crash Error
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

lwip_netconn_do_writemore is setting conn->write_offset to 0 on success and
returns to the application thread when finished. This works fine if no
fatal/routing error occurs.
If a fatal/routing error happens, conn->write_offset is not cleared which
causes the following assert when trying to close the socket after a
fatal/routing error occurs:

LWIP_ASSERT("already writing or closing", msg->conn->current_msg == NULL &&
    msg->conn->write_offset == 0);

On a fatal/routing error conn->write_offset should be set to 0.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 15 Feb 2016 12:53:49 PM GMT  Name: api_msg.patch  Size: 882B   By:
mave

<http://savannah.nongnu.org/bugs/download.php?file_id=36342>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?47154>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/