[lwip-devel] [patch #8759] Fix shadowing of global declaration

[Erik Ekman]

URL:
  <http://savannah.nongnu.org/patch/?8759>

                 Summary: Fix shadowing of global declaration
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: yarrick
            Submitted on: Mon 05 Oct 2015 09:16:26 AM GMT
                Category: PPP
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

Found one more shadowing. md5.h has function md5(), shadowed by md5 variable
in magic.c. 

https://travis-ci.org/yarrick/lwip-merged/jobs/83648416

gcc -g -Wall -DLWIP_UNIX_LINUX -DLWIP_DEBUG -pedantic -Werror -Wparentheses
-Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith
-Wcast-qual -Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align
-Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wno-address
-Wunreachable-code -Wuninitialized -Wlogical-op -I.
-I../../../../apps/httpserver_raw -I../../../../apps/shell
-I../../../../apps/tcpecho -I../../../../apps/udpecho
-I../../../../apps/snmp_private_mib -I../../../../apps/tcpecho_raw
-I../../../../../lwip/src/include -I../../../../ports/unix/include
-I../../../../../lwip/src -c ../../../../../lwip/src/netif/ppp/magic.c

../../../../../lwip/src/netif/ppp/magic.c: In function ‘magic_churnrand’:

../../../../../lwip/src/netif/ppp/magic.c:105:15: error: declaration of
‘md5’ shadows a global declaration [-Werror=shadow]

../../../../../lwip/src/include/netif/ppp/polarssl/md5.h:88:6: error: shadowed
declaration is here [-Werror=shadow]

../../../../../lwip/src/netif/ppp/magic.c: In function
‘magic_random_bytes’:

../../../../../lwip/src/netif/ppp/magic.c:165:15: error: declaration of
‘md5’ shadows a global declaration [-Werror=shadow]

../../../../../lwip/src/include/netif/ppp/polarssl/md5.h:88:6: error: shadowed
declaration is here [-Werror=shadow]

cc1: all warnings being treated as errors



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 05 Oct 2015 09:16:26 AM GMT  Name:
0001-PPP-Fix-shadowing-of-global-declaration.patch  Size: 3kB   By: yarrick

<http://savannah.nongnu.org/patch/download.php?file_id=35072>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?8759>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/