Re: [lwip-devel] [bug #46093] Move IP6_ROUTE() hook to after LL processing

[pradip de]

Hi Ivan,

Thanks for filing this bug. However, to be clear, one assumption here is that the LWIP_HOOK_IP6_ROUTE would be used for routes with prefix length less than 64. What if the hook wants to match against prefixes greater than 64 bits?  

Would it be better to move the LWIP_HOOK_IP6_ROUTE outside and have the ip6_route() function as the default hooked routing function. So, that if someone is replacing the ip6_route() with their own hook they would have to implement routing for all prefixes. 

Thanks,

Pradip

On Thu, Oct 1, 2015 at 8:28 AM, Ivan Delamer <address@hidden> wrote:

URL:
  <http://savannah.nongnu.org/bugs/?46093>

                 Summary: Move IP6_ROUTE() hook to after LL processing
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: idelamer
            Submitted on: Thu 01 Oct 2015 09:28:32 AM MDT
                Category: IPv6
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: idelamer
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 1.5.0
            lwIP version: git head

    _______________________________________________________

Details:

ip6_route() starts with a call to LWIP_HOOK_IP6_ROUTE() if defined.

However, this is done before checking if the destination is a link-local
address, or an address that matches a configured subnet.

It seems that it would make more sense to have the hook just before the call
to nd6_select_router(), after the LL and local subnet processing.

This way, the hook function can work on remote addresses and doesn't need to
duplicate the logic for local addresses.






    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?46093>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/


_______________________________________________
lwip-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/lwip-devel