[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #8678] Remove warnings in unit tests

From: Simon Goldschmidt
Subject: [lwip-devel] [patch #8678] Remove warnings in unit tests
Date: Wed, 05 Aug 2015 19:17:17 +0000
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.130 Safari/537.36

Update of patch #8678 (project lwip):

                  Status:                    None => Done                   
             Assigned to:                    None => goldsimon              
             Open/Closed:                    Open => Closed                 


Follow-up Comment #1:

Thanks for the patches. I always love to fix warnings :-)

However, I have comments and/or changes to a few:
- lwip-0005-test_etharp-Fix-warnings-about-incompatible-pointer-.patch: I
don't think I get the problem. You can cast a non-const pointer to a const
pointer, can't you? Only the opposite direction should make problems.

- lwip-0003-test_tcp_oos-Fix-warning-from-unsigned-signed-compar.patch: size_t
doesn't help: some compilers warn because the #defined constants used below
are signed, not unsigned. GCC has a lot of good warnings, but there are still
other compilers warning about different things :-)

- lwip-0002-test_tcp_oos-Remove-unused-method-tcp_oos_pbuf_count.patch:
tcp_oos_pbuf_count() is not always unused.

I'm using MSVC (for the unit tests at least) and unfortunately, it doesn't
warn about any of the things you've fixed.

However, I've committed things in a different way so this should hopefully be
fixed for you, too.


Reply to this item at:


  Nachricht gesendet von/durch Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]