[lwip-devel] FW: DHCP Unit tests fail

[Fabian Koch]

Another try on the lwIP-devel mailing list...

-----Original Message-----
From: address@hidden [mailto:address@hidden On Behalf Of Fabian Koch
Sent: Montag, 30. Juni 2014 16:24
To: Mailing list for lwIP users
Subject: [lwip-users] DHCP Unit tests fail

Hey all,

I started using the unit tests with the unix port from lwip-contrib:

* git cloned lwIP and lwIP-contrib
* installed "check" (Ubuntu 12.04)

$ cd lwIP-contrib/ports/unix/check
$ make check
Running suite(s): UDP
TCP
TCP_OOS
MEM
PBUF
ETHARP
DHCP
97%: Checks: 38, Failures: 1, Errors: 0
../../../../lwip/test/unit/dhcp/test_dhcp.c:776:F:DHCP:test_dhcp_relayed:0: 
txpacket = 5
make: *** [check] Error 1


so I took a look at the dhcp tests at line 776 and without any knowledge of 
those tests, I found it odd that the check is for txpacket == 6 when a few 
lines above, the last check was for txpacket == 4 (unless the expectation here 
really is sending two packets.

So if I change line 776 to expect txpacket==5 it yields:

$ make check
Running suite(s): UDP
TCP
TCP_OOS
MEM
PBUF
ETHARP
DHCP
97%: Checks: 38, Failures: 1, Errors: 0
../../../../lwip/test/unit/dhcp/test_dhcp.c:206:F:DHCP:test_dhcp_relayed_0: 
data at pos 0, len 6 in packet 6 did not match
make: *** [check] Error 1


Can anyone tell me if my setup is wrong OR The unix-port has problems OR the 
unit tests for DHCP are not working at the moment?


Kind regards,
Fabian