[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #8446] LWIP IP Re-assembly timer optimization

From: Simon Goldschmidt
Subject: [lwip-devel] [patch #8446] LWIP IP Re-assembly timer optimization
Date: Mon, 19 May 2014 20:16:10 +0000
User-agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.137 Safari/537.36

Follow-up Comment #1, patch #8446 (project lwip):

Your patch is tempting, but it breaks dependencies: as it is now, lwIP core
files should not depend on the timer implementation. In other words, everyone
is free to implement a different timer implementation as long as the timers
are called as needed.

You can see a way to implement what you want in tcp.c/timer.c: TCP calls
tcp_timer_needed() when a timer is needed and timer.c then starts the timer if
it is not alreay running. This way, developers are free to implement a more
efficient way of timer handling in their port and have the TCP timer only
running when needed.

Would you mind rewriting your patch to fit this?


Reply to this item at:


  Nachricht gesendet von/durch Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]